User
Welcome, Guest. Please login or register.
September 07, 2010, 03:00:10 PM

Login with username, password and session length

Search
News
Try the Report Plugin for advanced reporting and group editing.
Latest Downloads
Links
« previous next »
Pages: [1] Print
Author Topic: Comment window much slower showing after last update  (Read 87 times)
Tom
Guinea Pig
****

Karma: +1/-0
Posts: 110


« on: July 29, 2010, 04:01:02 AM »

this is minor but kindof annoying all the same:

I have comment window set to on for most revisions. The popup comes up (I have the medium size one), the top half including the comment button is greyed out for a short while. Then it kicks in, 'un-greys' itself and the comment window shows. It's not painfully slow but takes a lot longer than it used to so decided to report it.

This coincided with install of the most recent update, so I'm presuming it's related... (1.7.0.3665)

Thanks
Logged
JohnRen
Mogware Developer
Rabbit
*****

Karma: +3/-0
Posts: 1045


« Reply #1 on: August 10, 2010, 12:45:19 AM »

The slight delay you have observed with the comment button becoming enabled actually has to do with a new feature we added on the last drop.

In the past, the bubble would not show itself until after the revision was created which could be a long time for larger files.  The new code allows the bubble to pop up almost instantly but because the comment button requires the revision to be completed before launching that form we were stuck with having to leave it disabled until after the revision has been completed...Ultimately, we hope to allow the user to launch the form before the revision has been created but the existing code had this limitation.

I'm sure you are now wondering why we made this change?
Well, this change now allows users the opportunity to cancel a revision if they decide to close the bubble before the revision has begun; We have a lot of users who work on extreamely large files that can take upto 30 seconds just to save the file so this now allows them the choice to skip the FileHamster revision via the bubble.  Plus, it allows FileHamster to give the visual revision bubble almost immediately without having to wait until after the file has finished being saved.  There is a new 'SkipRevisionIfBubbleClosed' option that you can enable.
Logged
Tom
Guinea Pig
****

Karma: +1/-0
Posts: 110


« Reply #2 on: August 10, 2010, 02:21:08 PM »

I'm sure you are now wondering why we made this change?
Well, this change now allows users the opportunity to cancel a revision if they decide to close the bubble before the revision has begun; We have a lot of users who work on extreamely large files that can take upto 30 seconds just to save the file so this now allows them the choice to skip the FileHamster revision via the bubble.  Plus, it allows FileHamster to give the visual revision bubble almost immediately without having to wait until after the file has finished being saved.  There is a new 'SkipRevisionIfBubbleClosed' option that you can enable.

am I happy? I requested something along these lines!
This means I will be able to use FH much more extensively - THANKs Smiley
Logged
Tom
Guinea Pig
****

Karma: +1/-0
Posts: 110


« Reply #3 on: August 12, 2010, 10:05:24 AM »

RE: Cancelling a revision by closing the bubble

I've tested this and it works by default - I have to show the bubbles for a bit longer so as I can get there to turn it off.

There is a new 'SkipRevisionIfBubbleClosed' option that you can enable.

As I said this worked by default - even though that setting is at False by default - I tried changing it a few times and it doesnt seem to make any difference ? (Does it need a programme restart?)
Doesnt bother me personally but...
Logged
JohnRen
Mogware Developer
Rabbit
*****

Karma: +3/-0
Posts: 1045


« Reply #4 on: August 12, 2010, 10:50:10 AM »

Actually, prolonging the bubble doesn't change the time period of when the bubble can be closed to cancel the revision.

When we implemented the new feature we simply popped up the bubble earlier; On the very first file change event;

As you noted earlier, the comment button was in a disabled/grayed out state for a little bit...The revision is only canceled when the bubble is closed BEFORE the file is finished being saved ( i.e. BEFORE the comment button becomes enabled )...Once the comment button becomes enabled, the revision has finished being copied so there is nothing to cancel.  We felt this design would be acceptable because the larger the file, the longer it takes to be saved subsequently increasing the window where the user can choose to cancel the creation of a particular revision; This feature was mostly being requested for the larger files so it seemed to work well...

However, in reading your post, you did give me an idea about how you can delay the revision creation process longer.  This is done via the 'Delay_CreateRevision' option where you can specify how much longer you want FileHamster to wait after the last file event before it begins the actual revision creation...Changing this setting should be what you want so you can have the bubble linger longer in the mode that will allow you to delete a particular revision.

To test this you will want to watch the revision list of the document and notice that no revisions are being created when you close the bubble before the revision has been finished.
« Last Edit: August 12, 2010, 10:56:57 AM by JohnRen » Logged
Tom
Guinea Pig
****

Karma: +1/-0
Posts: 110


« Reply #5 on: August 12, 2010, 11:00:18 AM »

Okay, got that, thanks

and did you get the bug report?
Logged
Pages: [1] Print 
« previous next »
Jump to:  

Powered by SMF 1.1.9 | SMF © 2006-2007, Simple Machines LLC Epsilon design by Bloc